Fix types to make "gulp typestest" succeeding #20641
Open
+23
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timvandermeij
approved these changes
Feb 9, 2026
Contributor
timvandermeij
left a comment
timvandermeij
left a comment
There was a problem hiding this comment.
r=me, with the comments addressed. Thanks!
Comment on lines
25
to
+26
| /** @typedef {import("../src/display/struct_tree_layer_builder.js").StructTreeLayerBuilder} StructTreeLayerBuilder */ | ||
| /** @typedef {import("../../../web/l10n.js").L10n} L10n */ |
Contributor
There was a problem hiding this comment.
The line above this one points to ../src/display/struct_tree_layer_builder.js but there is no src folder in the top-level folder that .. refers to, and the struct tree builder lives in the web/ folder instead. I assume that one is incorrect, and should be ../../../web/struct_tree_layer_builder.js instead?
| /** @typedef {import("../../web/struct_tree_layer_builder.js").StructTreeLayerBuilder} StructTreeLayerBuilder */ | ||
| // eslint-disable-next-line max-len | ||
| /** @typedef {import("../../web/comment_manager.js").CommentManager} CommentManager */ | ||
| // eslint-disable-next-line max-len |
Contributor
There was a problem hiding this comment.
If npx gulp typestest passes again with these changes, please also undo the change from aa4d0f7 in the scope of this MR to activate it again in the CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20616.